sts: Update to version 4.32.1, fix checkver & autoupdate, update homepage #16516
Conversation
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with sts
|
WalkthroughVersion bump from 4.29.1 to 4.32.1 for the Spring Tools for Eclipse package, migrating 64-bit download URLs from springsource.com to cdn.spring.io with updated artifact naming and configuration parameters including checksums and version detection regex. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/sts.json(2 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-10-16T15:59:21.258Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/fvim.json:45-49
Timestamp: 2025-10-16T15:59:21.258Z
Learning: In Scoop manifests, the `autoupdate.url` and `autoupdate.architecture.<arch>.url` fields must be valid URIs according to the JSON schema (defined with `"format": "uri"`). Variables like `$matchUrlx64` that contain only path segments must be combined with a base URL (e.g., `https://github.com/.../releases/download/`) to form a complete valid URI.
Applied to files:
bucket/sts.json
📚 Learning: 2025-09-05T09:41:52.653Z
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
Applied to files:
bucket/sts.json
📚 Learning: 2025-09-05T09:41:52.653Z
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format.
Applied to files:
bucket/sts.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (2)
bucket/sts.json (2)
10-11: URL and hash updates align with PR objectives.The download URL has been successfully migrated from
springsource.comtocdn.spring.io/spring-tools, and the artifact naming now usesspring-tools-for-eclipseprefix as required. The hash has been updated to match the new version and artifact.
33-35: Upstream provides .sha256 hash files — no action required.Verification confirms the Spring Tools CDN provides .sha256 hash files for release artifacts. The curl request to the cdn.spring.io URL returned HTTP 200 with a valid SHA256 hash. The autoupdate configuration change is valid and functional.
|
/verify |
|
All changes look good. Wait for review from human collaborators. sts
|
z-Fng
changed the title
|
/verify |
|
All changes look good. Wait for review from human collaborators. sts
|
z-Fng
changed the title
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/sts.json(2 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-10-16T15:59:21.258Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/fvim.json:45-49
Timestamp: 2025-10-16T15:59:21.258Z
Learning: In Scoop manifests, the `autoupdate.url` and `autoupdate.architecture.<arch>.url` fields must be valid URIs according to the JSON schema (defined with `"format": "uri"`). Variables like `$matchUrlx64` that contain only path segments must be combined with a base URL (e.g., `https://github.com/.../releases/download/`) to form a complete valid URI.
Applied to files:
bucket/sts.json
📚 Learning: 2025-09-05T09:41:52.653Z
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
Applied to files:
bucket/sts.json
📚 Learning: 2025-09-05T09:41:52.653Z
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format.
Applied to files:
bucket/sts.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (2)
bucket/sts.json (2)
4-4: Verify homepage URL change maintains accessibility to STS product information.The homepage was changed from
https://spring.io/tools/sts(product-specific) tohttps://spring.io/tools(general tools landing page). Confirm that users landing on the homepage can still find relevant information about Spring Tools for Eclipse and its download/documentation links.
10-12: Verify hash computation matches upstream published hash.The hash on line 11 was updated to use SHA256. Confirm by:
- Downloading the artifact from the URL on line 10
- Computing its SHA256 checksum
- Verifying it matches:
d266f169a95edbc2e74fe89c346bfda2e6f8cc6790e2d2ef0d2908fbc7a9d8d0This prevents silent corruption or downgrade attacks.
2 participants
Related: #16379
spring-tools-for-eclipse<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit